Re: [PATCH v3] staging: rtl8723bs: remove unused private debug counters

[Dan Carpenter]

On Thu, Jan 29, 2026 at 10:34:38AM -0600, Ethan Tidmore wrote:
> The driver maintains a private `struct debug_priv` embedded within
> `struct dvobj_priv` to track various error counters (e.g., suspend
> errors, alloc failures, RX drops).
> 
> These counters are incremented in various files but the data is
> never read or exposed to userspace.
> 
> Remove the unused `debug_priv` structure definition, the instance
> in `dvobj_priv`, and all associated increment operations across
> the driver to clean up the code.
> 
> This also removes the following helper functions which were used
> solely to update these counters:
>  - rtw_reset_rx_info()
>  - recv_indicatepkts_pkt_loss_cnt()
>  - rtw_hal_check_rxfifo_full()
> 
> ---
> v3:
>  - Squashed previous series into a single atomic patch to remove
>    definitions and usages simultaneously (Feedback from Dan Carpenter).
>  - Removed stray blank line in rtw_mlme.c (Feedback from Dan Carpenter).
>  - Removed unused variable 'fw_current_in_ps_mode' in rtl8723b_dm.c
>    to fix -Wunused-but-set-variable warning (Fixes kbuild bot failure).
> 
> Signed-off-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>
> ---

The changelog notes go after.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter