Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support
From: Niklas Cassel
Date: Fri Jan 30 2026 - 04:57:41 EST
On Fri, Jan 30, 2026 at 11:21:32AM +0900, Koichiro Den wrote:
> >
> > Koichiro (he is on To:),
> >
> > don't you think that it would be clearer if we had a:
> > return;
> >
> > here...
> >
> > I mean, a BAR can either have a BAR match mode mapping or a subrange mapping,
> > but not both... So continuing executing code beyond this point seems pointless,
> > possibly even confusing.
>
> Thanks for pinging. I agree it would be clearer. Since it's orthogonal to
> this series, would it be better if I sent a one-line patch?
Thank you Koichiro, I think a one liner patch for this would be nice.
You can also write in the changelog (after the ----) that Mani can squash
your one liner patch into the existing submap commit if he wants.
Kind regards,
Niklas