Re: [PATCH 2/3] arm64: dts: qcom: sm8550: Add tz-log node

[Konrad Dybcio]

On 1/29/26 8:46 AM, Aaron Kling via B4 Relay wrote:
> From: Lei Chen <quic_chenlei@xxxxxxxxxxx>
> 
> Add DT node to enable tz-log driver.
> 
> Signed-off-by: Lei Chen <quic_chenlei@xxxxxxxxxxx>
> Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> ---

It's nice that you preserved the original authorship.

Please extend the rather lackluster commit message to explain the
"why", which is notably different from the original downstream
addition, since your goal here is to mainly appease a grumpy
bootloader.

>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index e3f93f4f412ded9583a6bc9215185a0daf5f1b57..740e3c238e8ed0f162dd168291f6e307ace66e80 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -5136,6 +5136,14 @@ data-pins {
>  			};
>  		};
>  
> +		qcom_tzlog: tz-log@146aa720 {

If we were to implement qcom,tz-log upstream, this would definitely
not be a node randomly in the middle of /soc, rather a child of
imem, most likely.

Could you please check whether adding a qcom_tzlog label to *any*
node makes the BL happy enough? Does it need the properties that
this node has?

Konrad