Re: [PATCH v3 fwctl 2/5] fwctl/bnxt_en: Refactor aux bus functions to be more generic

[Pavan Chebbi]

> Hi Pavan,
>
> Various comments inline.  Please also make sure to run a few
> static analysis tools over the code. There seems to be a use
> after free that is pretty obvious in here, so I'd expect that
> to be picked up. That stuff is easier for tooling that humans!

Ok, I will respin for the UAF. I value your other comments, and I have
addressed them all until this patch. Because the new ones are not code
defects I am going to hold them off for a later time.
It seems like this auxdevice infra (which is not authored by me) can
be improved and simplified. I will plan to do that.
I have tried to improve it as best as I can to accommodate fwctl which
is the primary goal of the series.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature