Re: [PATCH v2 1/2] arm64: dts: qcom: talos: Flatten usb controller nodes

[Krishna Kurapati]

On 1/29/2026 4:58 PM, Konrad Dybcio wrote:
> On 1/28/26 5:09 PM, Krishna Kurapati wrote:
> > On 1/28/2026 4:01 PM, Konrad Dybcio wrote:
> > > On 1/28/26 7:27 AM, Krishna Kurapati wrote:
> > > > Flatten usb controller nodes and update to using latest bindings
> > > > and flattened driver approach.
> > > >
> > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > > > ---
> > >
> > > Have you checked whether this brings about the same crash-on-suspend
> > > issue as it does on Hamoa?
> > >
> > > https://lore.kernel.org/linux-arm-msm/71c15a78-7a50-4913-b677-e5308fcabfad@xxxxxxxxxxxx/
> >
> > Hi Konrad,
> >
> >   Yes, I did check system suspend use case after flattening and there is no crash seen.
> >
> >   The only issue I observed (both before and after flattening) is that waking up from bus suspend, there is an enumeration failure on second port in host mode, and an xHCI CMD_RUN timeout occurs. The issue is gone if we keep controller GDSC flags as RET_ON (not the right solution though). But this issue has nothing to do with flattening. I will sync up with clocks team and try to fix that host mode issue.
>
> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index 75716b4a58d6..7e7f4eae8a98 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -4559,7 +4559,7 @@ usb_2: usb@a8f8800 {
>                                   <&gcc GCC_AGGRE_USB2_SEC_AXI_CLK>,
>                                   <&gcc GCC_USB20_SEC_SLEEP_CLK>,
>                                   <&gcc GCC_USB20_SEC_MOCK_UTMI_CLK>,
> -                                <&gcc GCC_USB2_PRIM_CLKREF_CLK>;
> +                                <&gcc GCC_USB3_SEC_CLKREF_CLK>;

I tried this out but it didn't work.

Regards,
Krishna,