[PATCH] thermal/drivers/qcom/lmh: Remove spurious IRQF_ONESHOT

From: Mark Brown

Date: Fri Jan 30 2026 - 12:02:21 EST


The lmh driver triggers a WARN_ON() due to requesting an interrupt with
IRQF_ONESHOT without a threaded handler:

[ 17.414825] WARNING: kernel/irq/manage.c:1502 at __setup_irq+0xd0/0x7a0, CPU#7: (udev-worker)/154

...

2361 18:49:55.941384 <4>[ 17.415074] __setup_irq+0xd0/0x7a0 (P)
2362 18:49:55.981820 <4>[ 17.415085] request_threaded_irq+0xec/0x1a4
2363 18:49:55.982122 <4>[ 17.415095] devm_request_threaded_irq+0x80/0x134
2364 18:49:55.982365 <4>[ 17.415103] lmh_probe+0x31c/0x4c8 [lmh]
2365 18:49:55.982594 <4>[ 17.415118] platform_probe+0x5c/0x98

This warning is there because IRQF_ONESHOT is only meaningful when there is
a threaded interrupt handler and this driver does not register one. Just
remove IRQF_ONESHOT, it wasn't doing anything.

Reported-by: Aishwarya TCV <Aiswarya.TCV@xxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
---
drivers/thermal/qcom/lmh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
index ddadcfada513..b6b7f1193c44 100644
--- a/drivers/thermal/qcom/lmh.c
+++ b/drivers/thermal/qcom/lmh.c
@@ -220,8 +220,7 @@ static int lmh_probe(struct platform_device *pdev)
/* Disable the irq and let cpufreq enable it when ready to handle the interrupt */
irq_set_status_flags(lmh_data->irq, IRQ_NOAUTOEN);
ret = devm_request_irq(dev, lmh_data->irq, lmh_handle_irq,
- IRQF_ONESHOT | IRQF_NO_SUSPEND,
- "lmh-irq", lmh_data);
+ IRQF_NO_SUSPEND, "lmh-irq", lmh_data);
if (ret) {
dev_err(dev, "Error %d registering irq %x\n", ret, lmh_data->irq);
irq_domain_remove(lmh_data->domain);

---
base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377
change-id: 20260130-thermal-lmh-oneshot-5ce7022bbf26

Best regards,
--
Mark Brown <broonie@xxxxxxxxxx>