Re: Re: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor

[Conor Dooley]

On Fri, Jan 30, 2026 at 10:00:15AM +0800, Huan He wrote:
> > > > > 
> > > > > Add device tree binding documentation for ESWIN EIC7700 Process, Voltage
> > > > > and Temperature sensor.
> > > > > 
> > > > > The EIC7700 SoC integrates two PVT instances for monitoring SoC and DDR
> > > > > power domains respectively.
> > > > > 
> > > > > Signed-off-by: Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx>
> > > > > Signed-off-by: Huan He <hehuan1@xxxxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >  .../bindings/hwmon/eswin,eic7700-pvt.yaml     | 70 +++++++++++++++++++
> > > > >  1 file changed, 70 insertions(+)
> > > > >  create mode 100644 Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..f4ba228924fe
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> > > > > @@ -0,0 +1,70 @@
> > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > > +%YAML 1.2
> > > > > +---
> > > > > +$id: http://devicetree.org/schemas/hwmon/eswin,eic7700-pvt.yaml#
> > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > +
> > > > > +title: ESWIN EIC7700 PVT Sensor
> > > > > +
> > > > > +maintainers:
> > > > > +  - Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx>
> > > > > +  - Huan He <hehuan1@xxxxxxxxxxxxxxxxxx>
> > > > > +
> > > > > +description:
> > > > > +  ESWIN EIC7700 SoC integrates embedded process, voltage and temperature
> > > > > +  sensors to monitor the internal SoC environment. The system includes two
> > > > > +  PVT sensor instances. The PVT0 monitors the main SoC power domain. The
> > > > > +  PVT1 sensor monitors the DDR core power domain.
> > > > > +
> > > > > +allOf:
> > > > > +  - $ref: /schemas/hwmon/hwmon-common.yaml#
> > > > 
> > > > FYI, including this is kinda pointless because you have the label
> > > > property defined below and your "additionalProperties: false" blocks
> > > > shunt-resistor-micro-ohms from being used.
> > > 
> > > I plan to keep the $ref: /schemas/hwmon/hwmon-common.yaml in use, change
> > > the original additionalProperties: false to unevaluatedProperties: false,
> > > and remove the label definition from our schema since it is already
> > > provided by hwmon-common.yaml. Could you please confirm if this
> > > modification conforms to the community standards?
> > 
> > That's fine. Does the shunt resistor property apply on your platform?
> 
> The shunt-resistor-micro-ohms property does not apply to our platform. We
> only use the label property from hwmon-common.yaml.

You could just remove
  label:
    description:
      Human readable identifier used to distinguish between different PVT
      instances. Typically "pvt0" for SoC PVT sensor and "pvt1" for DDR
      core PVT sensor.

and do
  label: true

or leave it as-is.

I don't mind.

Attachment: signature.asc
Description: PGP signature