Re: [PATCH] thermal/drivers/qcom/lmh: Remove spurious IRQF_ONESHOT
From: Rafael J. Wysocki
Date: Fri Jan 30 2026 - 13:14:08 EST
On Fri, Jan 30, 2026 at 7:09 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Jan 30, 2026 at 07:06:06PM +0100, Rafael J. Wysocki wrote:
> > On Fri, Jan 30, 2026 at 5:55 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> > > This warning is there because IRQF_ONESHOT is only meaningful when there is
> > > a threaded interrupt handler and this driver does not register one. Just
> > > remove IRQF_ONESHOT, it wasn't doing anything.
>
> > Daniel, do you want me to pick up this one? I can still push it for
> > 6.19 as a fix.
>
> FWIW the WARN_ON() is introduced in -next so won't be seen in v6.19
> (though the issue has been there since forever).
OK, so it need not go into 6.19, but it would be good to have in 6.20/7.0.