Re: [PATCH v2 04/20] mailbox: bcm-ferxrm-mailbox: Use default primary handler

From: Jassi Brar

Date: Sun Feb 01 2026 - 19:56:42 EST


On Wed, Jan 28, 2026 at 3:55 AM Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
>
> request_threaded_irq() is invoked with a primary and a secondary handler
> and no flags are passed. The primary handler is the same as
> irq_default_primary_handler() so there is no need to have an identical
> copy.
> The lack of the IRQF_ONESHOT can be dangerous because the interrupt
> source is not masked while the threaded handler is active. This means,
> especially on LEVEL typed interrupt lines, the interrupt can fire again
> before the threaded handler had a chance to run.
>
> Use the default primary interrupt handler by specifying NULL and set
> IRQF_ONESHOT so the interrupt source is masked until the secondary
> handler is done.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Applied to mailbox/for-next
Thanks
Jassi