Re: [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers

[Jassi Brar]

On Wed, Jan 28, 2026 at 6:32 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> mailbox_client.h should be used by mailbox consumer drivers, not mailbox
> controller (provider) drivers. The affected drivers do not use any mailbox
> client APIs, so the include can be safely removed.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> Changes in v2:
> - Drop changes to pcc.c
> - Update patch subject and commit log
> - Link to v1: https://lore.kernel.org/r/20260127-mailbox-v1-v1-1-cf15d7cece48@xxxxxxx
> ---
>  drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>  drivers/mailbox/cv1800-mailbox.c     | 1 -
>  drivers/mailbox/omap-mailbox.c       | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index 41f79e51d9e5a92089a3fd798e848d837fb2775a..5d278bb5a4c0635dfc46b4a6dc3addf0b3b5d1be 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -26,7 +26,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/kernel.h>
>  #include <linux/mailbox_controller.h>
> -#include <linux/mailbox_client.h>
>  #include <linux/mailbox/brcm-message.h>
>  #include <linux/module.h>
>  #include <linux/msi.h>
> diff --git a/drivers/mailbox/cv1800-mailbox.c b/drivers/mailbox/cv1800-mailbox.c
> index 4761191acf782654c1724df2c9cc619e1d7c985c..4bca9d8be4ba2c8debf6e48a5ddc2873f14b64fd 100644
> --- a/drivers/mailbox/cv1800-mailbox.c
> +++ b/drivers/mailbox/cv1800-mailbox.c
> @@ -11,7 +11,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
>  #include <linux/kfifo.h>
> -#include <linux/mailbox_client.h>
>  #include <linux/mailbox_controller.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index 17fe6545875d01606b80e678fca82bf44f6eaffa..d9f100c18895224cf323b073db93ce94d7e16d18 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -21,7 +21,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/mailbox_controller.h>
> -#include <linux/mailbox_client.h>
>
>  #include "mailbox.h"
>
>
> ---
> base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
> change-id: 20260127-mailbox-v1-1461cd2955fe
>
> Best regards,
> --
> Peng Fan <peng.fan@xxxxxxx>
>
Applied to mailbox/for-next
Thanks
Jassi