Re: [PATCH v3 16/26] x86/virt/seamldr: Shut down the current TDX module

[Xu Yilun]

> +static int get_tdx_sys_info_handoff(struct tdx_sys_info_handoff *sysinfo_handoff)
> +{
> +	int ret = 0;
> +	u64 val;
> +
> +	if (tdx_supports_runtime_update(&tdx_sysinfo) &&
> +	    !(ret = read_sys_metadata_field(0x8900000100000000, &val)))
> +		sysinfo_handoff->module_hv = val;
> +
> +	return ret;
> +}
> +
>  static int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
>  {
>  	int ret = 0;
> @@ -115,6 +127,7 @@ static int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
>  	ret = ret ?: get_tdx_sys_info_tdmr(&sysinfo->tdmr);
>  	ret = ret ?: get_tdx_sys_info_td_ctrl(&sysinfo->td_ctrl);
>  	ret = ret ?: get_tdx_sys_info_td_conf(&sysinfo->td_conf);
> +	ret = ret ?: get_tdx_sys_info_handoff(&sysinfo->handoff);

Do all fields in sysinfo_handoff optional or just module_hv, if the
former, is it better:

	if (tdx_supports_runtime_update(&tdx_sysinfo)
		ret = ret ?: get_tdx_sys_info_handoff(&sysinfo->handoff);

>  
>  	return ret;
>  }
> -- 
> 2.47.3
>