Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

[Andreas Kemnade]

On Thu, 29 Jan 2026 00:47:06 -0500
Mithil Bavishi <bavishimithil@xxxxxxxxx> wrote:

> Create common device tree for Samsung Espresso series devices
> 
> Let's create a common tree for all the variants first, later we can
> device specific trees based on their screen sizes
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@xxxxxxxxx>
> ---
[...]
> +			OMAP4_IOPAD(0x0c0, WAKEUP_EN | PIN_INPUT | MUX_MODE3)

We had the discussion. This should be done via pinctrl irq if possible instead of
specifying WAKEUP_EN here, You had some trouble to understand how it can be done,
and we agreed to add the wakeup functionality as a follow-up concentrating just
on that detail and for now just remove WAKEUP_EN.
[...]
> +		mount-matrix =	"-1", "0", "0",
> +				"0", "1", "0",
> +				"0", "0", "1";
> +		};
> +
still this strange matrix. This is no rotation matrix. Determinant is -1.
Something is strange here, so also the idea in our earlier discussion was to
also postpone it and maybe separately discuss it with iio.

Regards,
Andreas