Re: [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips

[Greg Kroah-Hartman]

On Mon, Feb 02, 2026 at 08:07:48AM +0100, Luka Gejak wrote:
> Remove unused definitions and function declarations that were left over
> from other Realtek chips:
> 
> - Remove rtl8192c_translate_rx_signal_stuff() and
>   rtl8192c_query_rx_desc_status() function declarations from
>   rtl8192c_recv.h. These functions are declared but never implemented
>   or used in the 8723bs driver.
> 
> - Remove unused RECV_BLK_SZ, RECV_BLK_CNT, and RECV_BLK_TH defines from
>   rtl8192c_recv.h. These are not referenced anywhere in the driver.
> 
> - Remove unused MAX_PATH_NUM_* definitions for other chips (92CS, 8188E,
>   8192E, 8812A, 8821A, 8814A, 8822B) from odm.h. Only MAX_PATH_NUM_8723B
>   is actually used by the driver.

When you have to list the different things a patch does, that's a huge
hint that the change needs to be broken up into smaller patches.

Remember, each change can only do "one logical thing".

thanks,

greg k-h