Re: [PATCH v3 1/7] media: dt-bindings: Document SC8280XP/SM8350 Venus

[Dikshita Agarwal]

On 2/2/2026 2:44 PM, Dmitry Baryshkov wrote:
> On Mon, Feb 02, 2026 at 01:37:50PM +0530, Dikshita Agarwal wrote:
>>
>>
>> On 1/31/2026 1:03 PM, Dmitry Baryshkov wrote:
>>> On Fri, Jan 30, 2026 at 05:59:48PM +0530, Dikshita Agarwal wrote:
>>>>
>>>>
>>>> On 1/25/2026 9:02 PM, Dmitry Baryshkov wrote:
>>>>> From: Konrad Dybcio <konradybcio@xxxxxxxxxx>
>>>>>
>>>>> Both of these SoCs implement an IRIS2 block, with SC8280XP being able
>>>>> to clock it a bit higher and  with SM8350 having 4 VPP pipes, while
>>>>> SC8280XP having just 2.
>>>>>
>>>>> Document Iris2 cores found on these SoCs.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxxx>
>>>>> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
>>>>> [ bod: dropped dts video-encoder/video-decoder ]
>>>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>>>>> [db: dropped status, dropped extra LLCC interconnect]
>>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>>>>> ---
>>>>>  .../bindings/media/qcom,sm8350-venus.yaml          | 113 +++++++++++++++++++++
>>>>>  1 file changed, 113 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..d78bdc08d830
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8350-venus.yaml
>>>>> @@ -0,0 +1,113 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/media/qcom,sm8350-venus.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Qualcomm SM8350 Venus video encode and decode accelerators
>>>>
>>>> s/Venus/iris
>>>>
>>>>> +
>>>>> +maintainers:
>>>>> +  - Konrad Dybcio <konradybcio@xxxxxxxxxx>
>>>>> +
>>>>> +description: |
>>>>> +  The Venus Iris2 IP is a video encode and decode accelerator present
>>>>> +  on Qualcomm platforms
>>>>> +
>>>>> +allOf:
>>>>> +  - $ref: qcom,venus-common.yaml#
>>>>
>>>> Pls remove the reference to venus-common.yaml and follow schema of
>>>> sm8550-iris.yaml
>>>
>>> Why? For example, sm8750-iris uses venus-common.yaml.
>>
>> Ack — in that case sm8750‑iris should be aligned as well.
>> Since Krzysztof’s patch [1] removes all venus-common references from
>> sm8550‑iris, all *-iris platforms should follow the same convention IMO.
> 
> He has been dropping references to venus-common.yaml mostly (IIUC)
> because of the video-firmware. With the video-firmware being moved to
> sc7180, the issue is no longer present. I will check if it makes sense
> to keep (and use) venus-common or if it makes more sense to stop using
> it.
> 

Ack, we should keep it consistent for all *-iris YAMLs.

Thanks,
Dikshita

>>
>> [1]:
>> https://lore.kernel.org/linux-media/20250823155349.22344-2-krzysztof.kozlowski@xxxxxxxxxx/
>