Re: [PATCH 5/8] irqchip/loongson-pch-lpc: add OF init code

[Thomas Gleixner]

On Mon, Feb 02 2026 at 13:50, Icenowy Zheng wrote:
> 在 2026-02-01星期日的 17:19 +0100，Thomas Gleixner写道：
>> On Sat, Jan 31 2026 at 17:45, Icenowy Zheng wrote:
>> 
>> > As the (kernel-internally) OF-based MIPS Loongson-3 systems can
>> > also
>> 
>> What are kernel-internally systems?
>
> I mean kernel-internally-OF-based. These devices' firmware does not
> ship DT, but Linux kernel ships some DTs and pick one by arch code.
>
> Do you have any suggestions for rewording to make this more clear? Or
> should I just stop to mention this implementaion detail?

It's irrelevant for the driver where the device tree comes from, no?

>> > +{
>> > +       int parent_irq;
>> > +       struct fwnode_handle *irq_handle;
>> > +       struct resource res;
>> 
>> Variable ordering.
>
> Is there any rule for the ordering?

I gave you the link in the other reply.

>> If pch_lpc_init() fails the parent interrupt mapping is leaked, no?
>
> I don't know any reverse operation for irq_of_parse_and_map(), and most

irq_dispose_mapping()

> implementations I see has no cleanup codepath for this parent IRQ.

You looked at the wrong drivers then :)