Re: [PATCH] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_signal_event_controls()

[Richard Fitzgerald]

On 31/01/2026 10:33 pm, Ziyi Guo wrote:
> cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control()
> which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held.
>
> Add mutex_lock()/mutex_unlock() around the control list iteration in
> cs_dsp_signal_event_controls() to fix the missing lock protection.
>
> Signed-off-by: Ziyi Guo <n7l8m4@xxxxxxxxxxxxxxxxxx>

I don't think this is the correct fix.

The mutex_lock() in cs_dsp_stop() should be at the top of the function.
Compare with cs_dsp_run().