Re: [PATCH v2 5/8] media: venus: scale MMCX power domain on SM8250

[Dmitry Baryshkov]

On 02/02/2026 12:02, Konrad Dybcio wrote:
> On 2/1/26 11:49 AM, Dmitry Baryshkov wrote:
> > On SM8250 most of the video clocks are powered by the MMCX domain, while
> > the PLL it powered on by the MX domain. Extend the driver to support
> > scaling both power domains, while keeping compatibitility with the
> > existing DTs, which define only the MX domain.
> >
> > Fixes: 0aeabfa29a9c ("media: venus: core: add sm8250 DT compatible and resource data")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > @@ -904,6 +904,12 @@ static int vcodec_domains_get(struct venus_core *core)
> >   
> >   	/* Attach the power domain for setting performance state */
> >   	ret = devm_pm_domain_attach_list(dev, &opp_pd_data, &core->opp_pmdomain);
> > +	/* backwards compatibility for incomplete ABI SM8250 */
>
> "eeeh", I'd rather error out since it can't guarantee to have its
> power fully on

That would break backwards compatibility, so... it's not possible.

> Konrad
>
> > +	if (ret == -ENODEV &&
> > +	    of_device_is_compatible(dev->of_node, "qcom,sm8250-venus")) {
> > +		opp_pd_data.num_pd_names--;
> > +		ret = devm_pm_domain_attach_list(dev, &opp_pd_data, &core->opp_pmdomain);
> > +	}
> >   	if (ret < 0)
> >   		return ret;
> >   


--
With best wishes
Dmitry