Re: [PATCH 2/2] ARM: dts: aspeed: add Meta SanMiguel BMC

[Andrew Lunn]

> +&mac0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	phy-mode = "rgmii-rxid";

That is an odd PCB design, with an extra long TX clock line, but a
short RX clock line. Please check the schematics to make sure this is
correct.

> +	max-speed = <1000>;

Can this device do faster than 1G?

> +	phy-handle = <&ethphy0>;
> +	pinctrl-0 = <&pinctrl_rgmii1_default>;
> +};

	Andrew