[RESEND] Re: [PATCH] printk: Fix _DESCS_COUNT type for 64-bit systems
From: feng.zhou
Date: Mon Feb 02 2026 - 10:09:32 EST
Hi John and maintainers,
(Resending to the list - apologies for the initial off-list reply)
On Mon, Feb 2, 2026, John Ogness wrote:
> This is important to us as well! And we really do want those
> wrap-arounds to happen early.
> Your v1 is certainly OK as-is. I just want to do some more investigating
> and testing. With your patch it will be the first time we experience
> descriptor ID wraps.
>
> As to the other U->UL conversion, I really have no preference. Let's
> just wait a bit in case Petr wants to comment.
Thank you for the feedback! I understand v1 is acceptable and you're doing
additional testing. I'll wait for Petr's comments and your investigation
results before any further action.
For the record, here's a summary of our off-list discussion:
1. Early wrap-around testing is important for the printk_ringbuffer design
itself, not just for matching documentation.
2. John noted this is interesting because it will be the first time descriptor
ID wraps are actually exercised in practice.
3. There's a similar issue with the text buffer array size definition using 1U,
but we agreed to wait for broader maintainer input on whether to address it
in the same patch or separately.
I apologize for not using "Reply All" initially - I'm still learning the
kernel development process. I'll make sure all future communications stay
on-list.
Thanks again for your patience and guidance!
Best regards,
Zhou