Re: [PATCH v11 2/3] rust: leds: split generic and normal led classdev abstractions up

From: Gary Guo

Date: Mon Feb 02 2026 - 10:46:07 EST


On Mon Feb 2, 2026 at 1:52 PM GMT, Markus Probst wrote:
> Move code specific to normal led class devices into a separate file and
> introduce the `led::Mode` trait to allow for other types of led class
> devices in `led::LedOps`.
>
> Signed-off-by: Markus Probst <markus.probst@xxxxxxxxx>

This patch deleted a lot of code that's added in the previous one.

Could you structure it in a way without doing this?

Best,
Gary

> ---
> MAINTAINERS | 1 +
> rust/kernel/led.rs | 245 ++++++----------------------------------------
> rust/kernel/led/normal.rs | 226 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 259 insertions(+), 213 deletions(-)