Re: [PATCH v3 11/12] i2c: qcom-geni: Store of_device_id data in driver private struct

From: Praveen Talari

Date: Mon Feb 02 2026 - 11:22:46 EST

Hi Konrad,

On 1/30/2026 5:59 PM, Konrad Dybcio wrote:
On 1/12/26 11:47 AM, Praveen Talari wrote:
To avoid repeatedly fetching and checking platform data across various
functions, store the struct of_device_id data directly in the i2c
private structure. This change enhances code maintainability and reduces
redundancy.

Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
---
drivers/i2c/busses/i2c-qcom-geni.c | 32 ++++++++++++++++--------------
1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index b0a18e3d57d9..1c9356e13b97 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -77,6 +77,13 @@ enum geni_i2c_err_code {
#define XFER_TIMEOUT HZ
#define RST_TIMEOUT HZ
+struct geni_i2c_desc {
+ bool has_core_clk;
+ char *icc_ddr;

Again, this should be a NOP after patch 1, that we can drop
Will do in next patch.

Thanks,
Praveen

Konrad