Re: [PATCH net] bonding: Fix header_ops type confusion

From: Eric Dumazet

Date: Mon Feb 02 2026 - 12:12:33 EST


On Wed, Jan 28, 2026 at 11:46 AM 戸田晃太 <kota.toda@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Here is the patch with the barriers added, based on v6.12.67.
>
> However, as Yuki said, we are wondering if this would be considered an
> acceptable change
> from the perspective of the maintainers (or in terms of Linux kernel
> culture). This is because
> the patch adds `READ_ONCE` to several locations outside of bonding subsystem.
> Please let me know if you have any concerns regarding this point.
>
> > Also, please clarify what happens with stacks of two or more bonding devices ?
>
> To clarify, currently the `header_ops` of the bottom-most
> interface are used regardless of the number of bonding layers.
> This patch changes it so that `&bond->bond_header_ops` is used
> as the bond device's `header_ops`, regardless of the stack depth.

Could you try to cook a patch series perhaps ?

The READ_ONCE()/WRITE_ONCE() on dev->header_ops->cache could be done separately.

Thanks.