Re: [PATCH 8/9] cxl/core: Add dax_kmem_region and sysram_region drivers
From: Gregory Price
Date: Mon Feb 02 2026 - 13:23:55 EST
On Mon, Feb 02, 2026 at 06:20:15PM +0000, Jonathan Cameron wrote:
> >
> > +/**
> > + * struct cxl_sysram_region - CXL RAM region for system memory hotplug
> > + * @dev: device for this sysram_region
> > + * @cxlr: parent cxl_region
> > + * @hpa_range: Host physical address range for the region
> > + * @online_type: Memory online type (MMOP_* 0-3, or -1 if not configured)
>
> Ah. An there's our reason for an int. Can we just add a MMOP enum value
> for not configured yet and so let us use it as an enum?
> Or have a separate bool for that and ignore the online_type until it's set.
>
I think the latter is more reasonably, MMOP_UNCONFIGURED doesn't much
make sense for memory_hotplug.c
ack.
~Gregory