Re: [syzbot] [input?] [usb?] WARNING in asus_remove

[Jiri Kosina]

On Mon, 2 Feb 2026, Jiri Kosina wrote:

> > #syz test
> > --- a/drivers/hid/hid-asus.c
> > +++ b/drivers/hid/hid-asus.c
> > @@ -960,8 +960,8 @@ static int asus_input_configured(struct hid_device *hdev,
> > struct hid_input *hi)
> >  	}
> >  
> >  	if (drvdata->quirks & QUIRK_HID_FN_LOCK) {
> > -		drvdata->fn_lock = true;
> >  		INIT_WORK(&drvdata->fn_lock_sync_work, asus_sync_fn_lock);
> > +		drvdata->fn_lock = true;
> >  		asus_kbd_set_fn_lock(hdev, true);
> >  	}
> >  @@ -1343,7 +1343,7 @@ static void asus_remove(struct hid_device *hdev)
> >  		cancel_work_sync(&drvdata->kbd_backlight->work);
> >  	}
> >  -	if (drvdata->quirks & QUIRK_HID_FN_LOCK)
> > +	if ((drvdata->quirks & QUIRK_HID_FN_LOCK) && drvdata->fn_lock)
> >  		cancel_work_sync(&drvdata->fn_lock_sync_work);
> >  
> >  	hid_hw_stop(hdev);
> 
> Thanks! Could you please submit this with proper changelog, signoff, etc?

Nevermind, it's 20260130155204.96831-1-chandna.sahil@xxxxxxxxx, I'll 
followup there.

-- 
Jiri Kosina
SUSE Labs