Re: [PATCH] iommu/vt-d: Treat PAGE_SNOOP and PWSNP separately

[Jason Gunthorpe]

On Mon, Feb 02, 2026 at 07:21:05PM +0000, Viktor Kleen wrote:
> The PASID_FLAG_PAGE_SNOOP and PASID_FLAG_PWSNP constants are identical.
> This will cause the pasid code to always set both or neither of the
> PGSNP and PWSNP bits in PASID table entries. However, PWSNP is a
> reserved bit if SMPWC is not set in the IOMMU's extended capability
> register, even if SC is supported.
> 
> This has resulted in DMAR errors when testing the iommufd code on an
> Arrow Lake platform. With this patch, those errors disappear and the
> PASID table entries look correct.
> 
> Fixes: 101a2854110fa ("iommu/vt-d: Follow PT_FEAT_DMA_INCOHERENT into the PASID entry")
> Signed-off-by: Viktor Kleen <viktor@xxxxxxxxx>
> ---
>  drivers/iommu/intel/pasid.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It looks like a typo to me too

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

It should also be:

Cc: stable@xxxxxxxxxxxxxxx

Jason