Re: [PATCH v10 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support

[Tianyang Zhang]

Hi, Thomas

在 2026/2/2 下午6:07, Thomas Gleixner 写道:
> On Mon, Feb 02 2026 at 17:10, Tianyang Zhang wrote:
> > +static inline void redirect_write_reg64(u32 node, u64 val, u32 reg)
> > +{
> > +	return writeq(val, REDIRECT_REG(reg, node));
>
> Again: What is this return for?
it is meaningless, and the return statement here will be removed later.
> > +static int redirect_table_init(struct irde_desc *irde)
> > +{
> > +	struct redirect_table *ird_table = &irde->ird_table;
> > +	unsigned long *bitmap;
> > +	struct folio *folio;
> > +	int node = irde->node;
>
> It seems to be really hard to do a length based sort.
>
> Oh well...
'''
struct redirect_table *ird_table = &irde->ird_table;
unsigned long *bitmap;
struct folio *folio;
int node;

node = irde->node
''''
Maybe this look better, I will try my best......

Thanks
Tianyang