Re: [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself

[David Howells]

Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:

> > +	if (!sinfo->sig->m_free) {
> > +		pr_notice_once("%s: No digest available\n", __func__);
> > +		return -EINVAL; /* TODO: MLDSA doesn't necessarily calculate an
> > +				 * intermediate digest. */
> 
> Is this logic going to change in the foreseeable future?

This is only used by IMA to retrieve an intermediate digest, so something will
need to be fixed to support use of ML-DSA in IMA, but I don't know what yet.
It doesn't, however, preclude the use of the rest of the code for module or
kexec signature verification, so I think it's reasonable enough just to emit a
warning and return an error here for now.

David