Re: [PATCH v2 1/2] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add TC9563 PCIe switch node for PCIe0

[Konrad Dybcio]

On 2/3/26 5:31 AM, Sushrut Shree Trivedi wrote:
> Add a node for the TC9563 PCIe switch connected to PCIe0. The switch
> has three downstream ports.Two embedded Ethernet devices are present
> on one of the downstream ports. All the ports present in the
> node represent the downstream ports and embedded endpoints.
> 
> Power to the TC9563 is supplied through two LDO regulators, which
> are on by default and are added as fixed regulators. TC9563 can be
> configured through I2C.
> 
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
> ---

Largely the same label comments as in patch 2

[...]

> +&{/} {
> +
> +	vreg_dc_12v: regulator-vreg-dc-12v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VREG_DC_12V";
> +
> +		regulator-always-on;
> +		regulator-boot-on;

Nit: please move these boolean properties below min/max-microvolt

Konrad