Re: [PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger_enabled

From: Andy Shevchenko

Date: Tue Feb 03 2026 - 04:46:34 EST


On Mon, Feb 02, 2026 at 01:26:01PM +0200, Antoniu Miclaus wrote:
> Remove unused drdy_trigger_enabled field from bmi323_data
> struct. The field is declared but never accessed in the
> driver.

...

> struct bmi323_data {

> struct iio_mount_matrix orientation;
> enum bmi323_irq_pin irq_pin;
> struct iio_trigger *trig;
> - bool drdy_trigger_enabled;

Hmm... Not directly related to your series, but with it applied it makes sense
to revisit the structure layouts as they might be rearranged to occupy less
space.

> enum bmi323_state state;

For example, this enum, if moved closer to irq_pin, might result in less gap on
some architectures. (Probably not, as we use long, id est 'int' sized, enums.)

In any way, `pahole` can hint about that, but as I said, it's not for this
series.

> s64 fifo_tstamp, old_fifo_tstamp;
> u32 odrns[BMI323_SENSORS_CNT];

--
With Best Regards,
Andy Shevchenko