Re: [PATCH v4 06/13] iio: dac: ds4424: use device match data for chip info
From: Oleksij Rempel
Date: Tue Feb 03 2026 - 05:17:54 EST
On Tue, Feb 03, 2026 at 12:03:23PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 10:34:26AM +0100, Oleksij Rempel wrote:
> > Refactor the driver to use device match data instead of checking ID enums
> > in a switch statement.
> >
> > Define a `ds4424_chip_info` structure to hold variant-specific attributes
> > (currently just the channel count) and attach it directly to the I2C and
> > OF device ID tables.
> >
> > Use `client->name` instead of `id->name` to decouple the probe function
> > from the legacy `i2c_device_id` structure.
> >
> > This simplifies the probe function and makes it easier to add support for
> > new variants like DS4402/DS4404.
>
> ...
>
> > - indio_dev->name = id->name;
>
> > + indio_dev->name = client->name;
>
> Isn't this an ABI breakage?
I can't confirm it.
before all patches:
root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name
ds4424
after:
root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name
ds4424
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |