Re: [PATCH v2 next 3/5] iio: sca3000: stop interrupts via devm_add_action_or_reset()

[Harshit Mogalapalli]

Hi David,


On 03/02/26 04:34, David Lechner wrote:
> On 2/2/26 1:40 PM, Harshit Mogalapalli wrote:
> > sca3000_stop_all_interrupts() is moved above the probe routine so the
> > new function sca3000_disable_interrupts() used in probe can directly
> > call it without additional declaration.
> >
> > Used devm_add_action_or_reset() for shutting down the interrupts.
> >
> > No functional change intended.
> >
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> > ---
> > v1->v2: Jonathan found a broken tear down sequence that was introduced
> > by my ptach 3 in v1: https://lore.kernel.org/all/20260131163218.2a4b93e5@jic23-huawei/
> >
> > So first converted the interrupt disabling task to devm based call,
> > order of tear down is as follows after this patch: iio_unregister_device
> > is called in the remove() callback, post which any interrupts will be
> > disabled with devm_add_action_or_reset() call.
> > ---
> >   drivers/iio/accel/sca3000.c | 53 ++++++++++++++++++++++---------------
> >   1 file changed, 31 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> > index 37ef724d5dc5..4faffeea328c 100644
> > --- a/drivers/iio/accel/sca3000.c
> > +++ b/drivers/iio/accel/sca3000.c
> > @@ -1437,6 +1437,33 @@ static const struct iio_info sca3000_info = {
> >   	.write_event_config = &sca3000_write_event_config,
> >   };
> >   
> > +static int sca3000_stop_all_interrupts(struct sca3000_state *st)
>
> Return value is ignored now, so we can make this void and not return.
>
> > +{
> > +	int ret;
> > +
> > +	mutex_lock(&st->lock);
> > +	ret = sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1);
> > +	if (ret)
> > +		goto error_ret;
> > +	ret = sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR,
> > +				(st->rx[0] &
> > +				 ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER |
> > +				   SCA3000_REG_INT_MASK_RING_HALF |
> > +				   SCA3000_REG_INT_MASK_ALL_INTS)));
> > +error_ret:
> > +	mutex_unlock(&st->lock);
> > +	return ret;
> > +}
> > +
> > +static void sca3000_disable_interrupts(void *data)
> > +{
> > +	struct iio_dev *indio_dev = data;
> > +	struct sca3000_state *st = iio_priv(indio_dev);
> > +
> > +	/* Must ensure no interrupts can be generated after this! */
> > +	sca3000_stop_all_interrupts(st);
> > +}
>
> This wrapper doesn't seem necessary. We can combine to two functions
> above into one.

Thanks for the review, Sure, will remove this extra wrapper and add the 
needed things in the same sca3000_stop_all_interrupts() function.

Regards,
Harshit
>