Re: [PATCH v6 04/16] ntfs: update in-memory, on-disk structures and headers

[Namjae Jeon]

On Tue, Feb 3, 2026 at 2:47 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Tue, Feb 03, 2026 at 07:01:50AM +0900, Namjae Jeon wrote:
> > This patch updates the NTFS filesystem driver's in-memory and on-disk
> > structures.
> >
> > Key changes include:
> >
> >  - Reorganize the comments in headers for better readability. (Fix the
> >    warnings from checkpatch.pl also)
> >  - Refactoring of core structures ntfs_inode and ntfs_volume to
> >    support new features such as iomap, and others.
> >  - Introduction of `iomap` infrastructure (iomap.h) and initial
> >    support for reparse points (reparse.h) and EA attribute(ea.h)
> >  - Remove unnecessary types.h and endian.h headers.
>
> Key changes include once again does not really add value here, and
> a lot of maintainers hate the "This patch" wording.
>
> Suggested alternate version:
>
> Update the NTFS filesystem driver's in-memory and on-disk structures:
>
>   - Introduce the `iomap` infrastructure and initial support for reparse
>     points and EA attribute.
>   - Refactor the core ntfs_inode and ntfs_volume structures to support
>     new features such as iomap.
>   - Remove the unnecessary types.h and endian.h headers.
>   - Reorganize the comments in headers for better readability, including
>     fixing warnings from checkpatch.pl.
Okay, I will use this in the next version.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks!