Re: [PATCH v4 2/4] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()
From: Andy Shevchenko
Date: Tue Feb 03 2026 - 10:12:28 EST
On Sun, Feb 01, 2026 at 04:29:59AM +0900, Minu Jin wrote:
> replaces the wrapper function rtw_zmalloc() with kzalloc().
>
> I reviewed all the call sites to determine the appropriate GFP flags:
> - GFP_KERNEL: Used for initialization and configuration paths.
> init/probe, config/setup
>
> - GFP_ATOMIC: Used for critical real-time paths.
> including interrupts, timer handler, region where spinlocks are held
>
> Replace sizeof(struct val) with sizeof(*ptr).
> Use kmemdup() where possible.
Shouldn't be here. Are there kmemdup() conversions?
So, collect kmemdup() in the first (currently absent) patch followed by
kmalloc() followed by this change.
> Remove blank line after kzalloc().
--
With Best Regards,
Andy Shevchenko