Re: [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers

From: Harshit Mogalapalli

Date: Tue Feb 03 2026 - 10:59:33 EST


On 03/02/26 20:47, Andy Shevchenko wrote:
On Tue, Feb 03, 2026 at 04:20:46AM -0800, Harshit Mogalapalli wrote:
Cache struct device *dev and feed it to the devm helpers to simplify
the probe function. No functional changes.

With or without below being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

- ret = devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev,
+ ret = devm_iio_kfifo_buffer_setup(dev, indio_dev,
&sca3000_ring_setup_ops);

Now make it a single line, it's just 83 characters.


Sure, will do. I thought the wrap limit is 80, but there are other instances in this file where the columns exceeded 80. Will address this in my next version.

Thanks!

Regards,
Harshit



if (ret)