Re: [PATCH v3 next 4/6] iio: sca3000: stop interrupts via devm_add_action_or_reset()

[Harshit Mogalapalli]

Hi Andy,

On 03/02/26 20:54, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 04:20:48AM -0800, Harshit Mogalapalli wrote:
> > sca3000_stop_all_interrupts() is moved above the probe routine so the
> > new function sca3000_disable_interrupts() used in probe can directly
> > call it without additional declaration.
> >
> > Used devm_add_action_or_reset() for shutting down the interrupts.
> > Make sca3000_stop_all_interrupts() return void now that it always hooks
> > into devm cleanup.
> >
> > No functional change intended.
>
> ...
>
> > +	mutex_lock(&st->lock);
>
> > +out_unlock:
> > +	mutex_unlock(&st->lock);
>
> You copy the code that is going to be removed. It means the conversion to
> guard()() should be done before this patch.

Sure will reorder the patches that way in my next version, thanks for 
the suggestion.


Regards,
Harshit