Re: [net-next,v3,03/11] net: phy: phy_link_topology: Track ports in phy_link_topology

[Maxime Chevallier]

Hi Simon,

On 03/02/2026 19:02, Simon Horman wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.

> 
> xa_alloc_cyclic() returns 1 when ID allocation wraps around, which is still a
> successful allocation. The check at line 126 above correctly uses `if (ret < 0)`
> for the phyindex allocation:

I already reported that to Chris, this review is incorrect.

xa_alloc_cyclic() doesn't return 1 upon wraparound. __xa_alloc_cyclic()
does :)

Maxime