Re: [PATCH v3 6/9] iio: amplifiers: ad8366: sort header includes

[Andy Shevchenko]

On Tue, Feb 03, 2026 at 11:24:12AM +0000, Rodrigo Alencar via B4 Relay wrote:

> Alphabetically sort include directives and drop include of linux/kernel.h.

Is it safe to be dropped? Do we have all necessary headers included?

...

> -#include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/gpio/consumer.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
>  #include <linux/bitrev.h>

> -

No, please keep linux/iio/* in a separate group after linux/*.

> +#include <linux/device.h>

What about this one? If you dropped kernel.h, do you really need device.h?

> +#include <linux/err.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/slab.h>
> +#include <linux/spi/spi.h>
> +#include <linux/sysfs.h>

...

I suggest to split this to two patches:
1) just pure sorting;
2) converting in accordance with IWYU principle.


-- 
With Best Regards,
Andy Shevchenko