Re: [PATCH v5 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

From: Mithil Bavishi

Date: Wed Feb 04 2026 - 02:48:43 EST


> We had the discussion. This should be done via pinctrl irq if possible instead of
> specifying WAKEUP_EN here, You had some trouble to understand how it can be done,
> and we agreed to add the wakeup functionality as a follow-up concentrating just
> on that detail and for now just remove WAKEUP_EN.

I think I may have understood what is to be done.
For example we have
pinctrl-single,pins = <
OMAP4_IOPAD(0x0bc, WAKEUP_EN | PIN_INPUT | MUX_MODE3)
>;

for wlan_host_wake, so the change needed to be done is from
interrupt-parent = <&gpio3>;
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "host-wake";
pinctrl-names = "default";
pinctrl-0 = <&wlan_host_wake>;

to

interrupts-extended = <&gpio3 17 IRQ_TYPE_LEVEL_HIGH>,
<&omap4_pmx_core 0x0bc>;
interrupt-names = "host-wake", "wakeup";

and remove the pinctrl?
Similarly for all in the omap4_pmx_core domain (wifi, bt, i2c as the
drivers support it)
No chnages for &omap4_pmx_wkup domain