Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer

[Miquel Raynal]

Hi Cheng Ming,

>> Looking at the current implementation, I really don't like the core
>> always calling in the "init" and the manufacturer driver reading the DT
>> and deciding whether or not it enables it.
>
> I agree. I will refactor the logic in v5 so that the core parses the
> generic DT properties (nand-enable-randomizer and
> nand-disable-randomizer).
>
> Then, spinand_randomizer_init will determine the state and pass a
> boolean argument to the set_randomizer callback, leaving the driver
> to strictly handle the hardware configuration.

Perfect.

Thanks,
Miquèl