Re: [PATCH v1 1/1] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op

From: Andy Shevchenko

Date: Wed Feb 04 2026 - 04:06:39 EST


On Wed, Feb 04, 2026 at 08:53:39AM +0100, Geert Uytterhoeven wrote:
> On Wed, 4 Feb 2026 at 02:11, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Feb 04, 2026 at 02:04:15AM +0100, Andy Shevchenko wrote:

...

> Definitely. I tried something similar a few years ago[1], but ran into build
> errors from the robots, and gave up due to lack of time.

For the matter of fact, I also get into errors from LKP (I compiled only part
of this, need to enable more to cover these cases).

> So for the principle:
> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks, I will do more tests and fixes and add your Ack.

> Ah, my local tree still has the following fix I never sent out, and still
> looks suboptimal:

Right, thanks for sharing, it's the same call robots are not okay with.

--
With Best Regards,
Andy Shevchenko