Re: [PATCH v4 next 3/6] iio: sca3000: make stop_all_interrupts() return void

[Harshit Mogalapalli]

Hi Andy,

On 04/02/26 14:33, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 10:11:58PM -0800, Harshit Mogalapalli wrote:
> > sca3000_stop_all_interrupts() is called only from the driver remove
> > path and its return value is discarded, so convert the helper to return
> > void.
> >
> > No functional change.
>
> Yeah, as I just replied, the prerequisite for this should be move upper in the
> code where you are going to use it in the future.

Sure, will do that! That would make reviewing simpler.
> ...
>
> >   	ret = sca3000_read_data_short(st, SCA3000_REG_INT_MASK_ADDR, 1);
> >   	if (ret)
> > -		goto error_ret;
>
> > -error_ret:
> > +		goto out_unlock;
>
> > +out_unlock:
>
> While this is correct change semantically, it's not needed as very soon
> the other patch drops this for good, hence leave the label name unmodified.

Agree, I was doubtful on which is the preferred approach as its not 
really a return anymore. But thanks for explaining.

Regards,
Harshit