Re: [PATCH v6 2/8] iio: core: add fixed point parsing with 64-bit parts

[Rodrigo Alencar]

On 26/02/04 11:57AM, Andy Shevchenko wrote:
> On Wed, Feb 04, 2026 at 09:42:55AM +0000, Rodrigo Alencar wrote:
> > On 26/02/04 03:45AM, Andy Shevchenko wrote:
> > > On Fri, Jan 30, 2026 at 10:06:43AM +0000, Rodrigo Alencar via B4 Relay wrote:
> 
> ...
> 
> > > > +static ssize_t iio_safe_strntou64(const char *str, const char **endp,
> > > > +				  u64 *result, size_t max_chars)
> > > > +{
> > > > +	u64 digit, acc = 0;
> > > > +	ssize_t idx = 0;
> > > > +
> > > > +	while (isdigit(str[idx]) && idx < max_chars) {
> > > > +		digit = str[idx] - '0';
> > > > +		if (unlikely(acc & (~0ull << 60))) {
> > > > +			if (check_mul_overflow(acc, 10, &acc) ||
> > > > +			    check_add_overflow(acc, digit, &acc))
> > > > +				return -ERANGE;
> > > > +		} else {
> > > > +			acc = acc * 10 + digit;
> > > > +		}
> > > > +		idx++;
> > > > +	}
> > > > +
> > > > +	*endp = str + idx;
> > > > +	*result = acc;
> > > > +	return idx;
> > > > +}
> > > 
> > > There is a development in the parse_integer in the lib/. I reviewed that series
> > > and hopefully it will go in. With that done, we better reuse the lib/ function.
> > > 
> > > https://lore.kernel.org/linux-hardening/20260202115451.290173-1-dmantipov@xxxxxxxxx/
> > 
> > In this patch, I see that it updates the overflow check, but I am not
> > seeing that function being exposed to other kernel modules.
> 
> Can the IIO be compiled as a module? If so, then we would need to export that
> function. (Note, we may export only for the exact module(s) in question, so
> nobody else will be able to use it. See EXPORT_SYMBOL_FOR_MODULES() macro.)

Yes, one can have an industrialio.ko.
Then, would it be fine to use:

EXPORT_SYMBOL_FOR_MODULES(_parse_integer_limit, "industrialio");

in lib/kstrtox.c; and:

#include "../../lib/kstrtox.h"

in drivers/iio/industrialio-core.c

that does not look pretty.

-- 
Kind regards,

Rodrigo Alencar