Re: [PATCH] HID: asus: Add check for cancelling fn_lock_sync_work
From: Jiri Kosina
Date: Wed Feb 04 2026 - 05:40:20 EST
On Mon, 2 Feb 2026, Alan Stern wrote:
> With no synchronization between the two routines, this patch cannot
> possibly be correct. There's nothing to prevent the CPU running
> asus_input_configured() from executing the assignment to
> drvdata->fn_lock before doing the INIT_WORK() (unless the INIT_WORK()
> call itself contains some synchronization -- but obviously the code
> shouldn't depend on that).
Ouch, you are of course right, that escaped my attention. Thanks a lot for
catching this, Alan!
Now dropped from the queue.
--
Jiri Kosina
SUSE Labs