Re: [PATCH net-next 07/15] mptcp: allow overridden write_space to be invoked

[Matthieu Baerts]

Hello,

On 03/02/2026 19:41, Matthieu Baerts (NGI0) wrote:
> From: Geliang Tang <tanggeliang@xxxxxxxxxx>
> 
> Future extensions with psock will override their own sk->sk_write_space
> callback. This patch ensures that the overridden sk_write_space can be
> invoked by MPTCP.
> 
> INDIRECT_CALL is used to keep the default path optimised.
> 
> This patch is shared early to ease discussions around future RFC and
> avoid confusions with this "fix" that is needed for different future
> extensions.
> 
> Suggested-by: Paolo Abeni <pabeni@xxxxxxxxxx>
> Co-developed-by: Gang Yan <yangang@xxxxxxxxxx>
> Signed-off-by: Gang Yan <yangang@xxxxxxxxxx>
> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
> ---
>  net/mptcp/protocol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index f4bfe91ca7f9..0bd1ee860316 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -975,7 +975,7 @@ static inline void mptcp_write_space(struct sock *sk)
>  	/* pairs with memory barrier in mptcp_poll */
>  	smp_mb();
>  	if (mptcp_stream_memory_free(sk, 1))
> -		sk_stream_write_space(sk);
> +		INDIRECT_CALL_1(sk->sk_write_space, sk_stream_write_space, sk);

Is it possible to drop only this patch from this series? It is
independent of the rest, and the AI review tool spotted that
sk->sk_write_space is not sk_stream_write_space by default.

I can send a v2 without this patch if preferred.

>  }
>  
>  static inline void __mptcp_sync_sndbuf(struct sock *sk)
> 

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.