Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda_hook

From: sun jian

Date: Wed Feb 04 2026 - 09:55:38 EST


On Wed, Feb 4, 2026 at 8:24 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> sun jian <sun.jian.kdev@xxxxxxxxx> wrote:
> > To keep the code concise while stripping the RCU attribute, I'll use
> > the typeof(*hook) * pattern
>
> No, please leave this alone, the code is fine as-is, all sparse warnings
> are due to missing annotations only.
Ack. You are right: I've double-checked my environment and confirmed
that adding the __rcu is sufficient to resolve those warnings.

I will just annotate them and leave other code as-is. V4 is on the way.

Regards,
sun jian