Re: [PATCH v2 6/6] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger

From: Lad, Prabhakar

Date: Wed Feb 04 2026 - 10:53:26 EST


Hi Thomas,

Thank you for the review.

On Wed, Feb 4, 2026 at 3:22 PM Thomas Gleixner <tglx@xxxxxxxxxx> wrote:
>
> On Tue, Feb 03 2026 at 23:18, Prabhakar wrote:
> > + /* 1) Bus errors (BEISR0..3) */
> > + for (k = 0; k < ICU_NUM_BE; k++) {
> > + st = readl(base + ICU_BEISR(k));
> > + if (!st)
> > + continue;
> > +
> > + writel_relaxed(st, base + ICU_BECLR(k));
> > + pr_debug("rzv2h-icu: BUS error k=%u status=0x%08x\n", k, st);
>
> Why hiding this behind pr_debug()? That's all diagnostic information
> which helps to monitor system health, no?
>
Agreed, I'll change it to pr_info() (and do the same for patch 5/6)

Cheers,
Prabhakar