Re: [PATCH v3] fs/resctrl: Add CONFIG_RESCTRL_ASSIGN_FIXED Kconfig entry

[Reinette Chatre]

Hi Ben,

On 2/4/26 4:02 AM, Ben Horgan wrote:
> Commit
> 
>   3b497c3f4f04 ("fs/resctrl: Introduce the interface to display monitoring modes")
> 
> introduced CONFIG_RESCTRL_ASSIGN_FIXED but left adding the Kconfig entry
> until it was necessary.

The changelog flow makes a big leap between its two paragraphs. I cannot tell why the
middle paragraph was dropped since it describes why the change is needed now to connect
with the opening context. Could you add a middle paragraph like below?

  Add CONFIG_RESCTRL_ASSIGN_FIXED in order to support MPAM where the counter assignment
  mode is indeed fixed. 

> 
> CONFIG_RESCTRL_ASSIGN_FIXED is a resctrl fs Kconfig option so handle
> attempts to modify counter assignment mode when it is enabled in resctrl fs
> rather than delegating to arch specific code.
> 
> Signed-off-by: Ben Horgan <ben.horgan@xxxxxxx>
> ---
Reinette