Re: [PATCH v1 1/1] bug: Mark __warn_printf() with __printf() attribute

[Andy Shevchenko]

+Cc: Arnd (just FYI)

On Mon, Dec 08, 2025 at 03:16:18PM +0100, Andy Shevchenko wrote:
> __warn_printf() is using printf() type of format, and compiler
> is not happy about them as is:
> 
> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   187 |                         vprintk(fmt, *args);
>       |                         ^~~~~~~
> 
> Fix the compilation errors by adding __printf() attribute.
> 
> Fixes: 5c47b7f3d1a9 ("bug: Add BUG_FORMAT_ARGS infrastructure")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  lib/bug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/bug.c b/lib/bug.c
> index edd9041f89f3..d7db57280ab7 100644
> --- a/lib/bug.c
> +++ b/lib/bug.c
> @@ -173,7 +173,7 @@ struct bug_entry *find_bug(unsigned long bugaddr)
>  	return module_find_bug(bugaddr);
>  }
>  
> -static void __warn_printf(const char *fmt, struct pt_regs *regs)
> +static __printf(1, 0) void __warn_printf(const char *fmt, struct pt_regs *regs)
>  {
>  	if (!fmt)
>  		return;

-- 
With Best Regards,
Andy Shevchenko