Re: [PATCH net-next v1] icmp: fix ip_rt_bug race in icmp_route_lookup reverse path

From: David Ahern

Date: Wed Feb 04 2026 - 11:30:19 EST


On 2/3/26 7:27 PM, Jiayuan Chen wrote:
>
> Thanks for the review.
>
> Paolo, I'll fix it in newer version.
>
> Regarding David's question about whether the message provides value:
> I think it could still be useful for debugging. If a user's configuration
> change causes ICMP packets to be silently dropped, there's currently no counter
> or indication of what happened. Adding a dedicated counter for this rare race
> condition seems overkill, so a rate-limited warning at least gives some visibility
> into the failure.
>
> That said, I'm open to dropping the message entirely if you both think silent handling
> is preferred. Let me know and I'll send a new version either way.
>

no strong opinions.