Re: [PATCH v4 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions

[Praveen Talari]

Hi Konrad,

On 2/4/2026 7:14 PM, Konrad Dybcio wrote:
> On 2/4/26 6:06 AM, Praveen Talari wrote:
> > Hi Konrad,
> >
> > On 2/3/2026 6:18 PM, Konrad Dybcio wrote:
> > > On 2/2/26 7:09 PM, Praveen Talari wrote:
> > > > To manage GENI serial engine resources during runtime power management,
> > > > drivers currently need to call functions for ICC, clock, and
> > > > SE resource operations in both suspend and resume paths, resulting in
> > > > code duplication across drivers.
> > > >
> > > > The new geni_se_resources_activate() and geni_se_resources_deactivate()
> > > > helper APIs addresses this issue by providing a streamlined method to
> > > > enable or disable all resources based, thereby eliminating redundancy
> > > > across drivers.
> > > >
> > > > Acked-by: Viken Dadhaniya <viken.dadhaniya@xxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
> > > > ---
> > >
> > > [...]
> > >
> > >
> > > >        disable_irq(gi2c->irq);
> > > > -    ret = geni_se_resources_off(&gi2c->se);
> > > > +
> > > > +    ret = geni_se_resources_deactivate(&gi2c->se);
> > > >        if (ret) {
> > > >            enable_irq(gi2c->irq);
> > > >            return ret;
> > > > -
> > > > -    } else {
> > > > -        gi2c->suspended = 1;
> > > >        }
> > > >    -    clk_disable_unprepare(gi2c->core_clk);
> > >
> > > I believe you can give gi2c->core_clk and desc->has_core_clk the boot
> > > with this patch since they're no longer referenced anywhere
> >
> > Sorry i didn't get you. Please share more on this.
>
> I think you can remove these fields from i2c-qcom-geni.c as they seem
> unused now
Got it. will update in next version.

Thanks,
Praveen Talari
> Konrad